CLN, TYP Remove string type hints #39299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
MarcoGorelli
added
Code Style
MarcoGorelli
force-pushed
the
no-string-hints
branch
from
d9d143c to
0af31a3
Compare
jreback
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
wow. lgtm. cc @simonjayhawkins
just have to make sure the author sticks around :->
rhshadrach
reviewed
Jan 21, 2021
Comment on lines
67
to
-68
| if TYPE_CHECKING: | ||
| from numpy.ma.mrecords import MaskedRecords | ||
|
|
||
| from pandas import Series |
There was a problem hiding this comment.
Curious what happened here. Series is imported inline below, so am I correct to say that this is sufficient for mypy?
There was a problem hiding this comment.
Thanks!
And yes, seems like it, e.g.:
t.py:
def foo() -> None:
a: List[int]
reveal_type(a)
from typing import List$ python3.8 -m mypy t.py
t.py:3: note: Revealed type is 'builtins.list[builtins.int]'
|
Thanks @MarcoGorelli. this is great. |
|
Thanks all for your kind words, much appreciated 🙏 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some background: there was some consensus on doing this here
Then here there was the suggestion to use
ast.parse, rather than regular expressions. I had a go at that, and made this into its own package: https://github.com/MarcoGorelli/no-string-hints , which I've included here as a pre-commit hookThe changes here are just a result of running
pre-commit run no-string-hints -a, and then addingfrom __future__ import annotationsto some files.